-
Notifications
You must be signed in to change notification settings - Fork 256
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
make it possible disable BlacklightHelper loading
- Loading branch information
Showing
2 changed files
with
13 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b35816
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious about the use case for this? At first I thought it was about actual Rails helper methods, but it's not, it's about whether or not to wrap a solr response in a SolrDocument object I guess? Sometimes you don't want to?
7b35816
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a bad commit and merged both. My immediate concern was the Rails helpers and class reloading problems I was having in a downstream app, but resolved that by injecting an actual helper into the app (which seems to help Rails understand what's going on).
The other thing in this commit was the wrapping solr documents, which I still think I need, but wasn't ready for shipping.. The use case there is using something like
draper
with those SolrDocuments to inject a little bit of controller context closer to the model.7b35816
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and, note that this is an orphaned commit, not in master or anything.