Upgrade to rubocop 0.63.0

.rubocop_todo.yml

@@ -1,12 +1,13 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-10-31 21:34:01 -0500 using RuboCop version 0.60.0.
+# on 2019-01-18 23:13:39 -0600 using RuboCop version 0.63.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # Offense count: 4
+# Cop supports --auto-correct.
 Capybara/CurrentPathExpectation:
   Exclude:
     - 'spec/features/alternate_controller_spec.rb'
@@ -126,12 +127,11 @@ Layout/SpaceInsideParens:
     - 'app/views/catalog/_document.rss.builder'
     - 'app/views/catalog/index.atom.builder'
 
-# Offense count: 27
+# Offense count: 13
 # Cop supports --auto-correct.
 # Configuration parameters: AllowInHeredoc.
 Layout/TrailingWhitespace:
   Exclude:
-    - 'app/views/catalog/_document.atom.builder'
     - 'app/views/catalog/_document.rss.builder'
     - 'app/views/catalog/index.atom.builder'
 
@@ -151,7 +151,7 @@ Lint/AmbiguousOperator:
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
     - 'spec/services/blacklight/search_service_spec.rb'
 
-# Offense count: 58
+# Offense count: 55
 Lint/AmbiguousRegexpLiteral:
   Exclude:
     - 'spec/controllers/catalog_controller_spec.rb'
@@ -211,7 +211,7 @@ Metrics/ClassLength:
 Metrics/CyclomaticComplexity:
   Max: 12
 
-# Offense count: 46
+# Offense count: 47
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 35
@@ -271,11 +271,10 @@ Performance/TimesMap:
   Exclude:
     - 'spec/views/catalog/index.atom.builder_spec.rb'
 
-# Offense count: 3
+# Offense count: 2
 Performance/UnfreezeString:
   Exclude:
     - 'lib/generators/blacklight/install_generator.rb'
-    - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
     - 'spec/helpers/blacklight_helper_spec.rb'
 
 # Offense count: 9
@@ -309,7 +308,7 @@ RSpec/EmptyExampleGroup:
   Exclude:
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
 
-# Offense count: 126
+# Offense count: 127
 # Configuration parameters: Max.
 RSpec/ExampleLength:
   Enabled: false
@@ -352,18 +351,33 @@ RSpec/MessageChain:
     - 'spec/presenters/blacklight/show_presenter_spec.rb'
     - 'spec/views/shared/_user_util_links.html.erb_spec.rb'
 
-# Offense count: 62
-# Configuration parameters: .
+# Offense count: 67
+# Configuration parameters: EnforcedStyle.
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
-  Enabled: false
+  Exclude:
+    - 'spec/controllers/catalog_controller_spec.rb'
+    - 'spec/helpers/blacklight/configuration_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight/render_constraints_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight/suggest_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight_helper_spec.rb'
+    - 'spec/helpers/catalog_helper_spec.rb'
+    - 'spec/lib/blacklight/configuration/facet_field_spec.rb'
+    - 'spec/models/blacklight/search_builder_spec.rb'
+    - 'spec/models/blacklight/suggest_search_spec.rb'
+    - 'spec/presenters/blacklight/index_presenter_spec.rb'
+    - 'spec/presenters/blacklight/show_presenter_spec.rb'
+    - 'spec/presenters/thumbnail_presenter_spec.rb'
 
-# Offense count: 339
+# Offense count: 345
 # Configuration parameters: AggregateFailuresByDefault.
 RSpec/MultipleExpectations:
   Max: 16
 
-# Offense count: 326
+# Offense count: 328
+# Configuration parameters: IgnoreSharedExamples.
 RSpec/NamedSubject:
   Enabled: false
 
@@ -398,7 +412,7 @@ RSpec/SubjectStub:
     - 'spec/lib/blacklight/search_state_spec.rb'
     - 'spec/services/blacklight/search_service_spec.rb'
 
-# Offense count: 117
+# Offense count: 118
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Enabled: false
@@ -502,12 +516,6 @@ Style/ConditionalAssignment:
   Exclude:
     - 'lib/blacklight/solr/response/spelling.rb'
 
-# Offense count: 1
-# Configuration parameters: AllowCoercion.
-Style/DateTime:
-  Exclude:
-    - 'spec/models/blacklight/solr/search_builder_spec.rb'
-
 # Offense count: 93
 Style/Documentation:
   Enabled: false
@@ -556,7 +564,7 @@ Style/HashSyntax:
   Exclude:
     - 'app/helpers/blacklight/url_helper_behavior.rb'
 
-# Offense count: 39
+# Offense count: 40
 # Cop supports --auto-correct.
 Style/IfUnlessModifier:
   Enabled: false
@@ -652,7 +660,7 @@ Style/Semicolon:
     - 'spec/models/blacklight/solr/repository_spec.rb'
     - 'spec/views/catalog/_paginate_compact.html.erb_spec.rb'
 
-# Offense count: 32
+# Offense count: 31
 # Cop supports --auto-correct.
 # Configuration parameters: MinSize.
 # SupportedStyles: percent, brackets

blacklight.gemspec

@@ -43,7 +43,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'engine_cart', '~> 2.1'
   s.add_development_dependency "equivalent-xml"
   s.add_development_dependency "simplecov"
-  s.add_development_dependency "rubocop", '~> 0.61.1'
+  s.add_development_dependency "rubocop", '~> 0.63.0'
   s.add_development_dependency "rubocop-rspec", '~> 1.8'
   s.add_development_dependency "i18n-tasks"
 end