Merge pull request #2336 from dkinzer/deep-dup-to_h-search_state

Do not mutate search_state internal params on .to_h

lib/blacklight/search_state.rb

@@ -47,7 +47,7 @@ def self.normalize_params(untrusted_params = {})
     end
 
     def to_hash
-      @params.dup
+      @params.deep_dup
     end
     alias to_h to_hash
 

spec/lib/blacklight/search_state_spec.rb

@@ -66,6 +66,18 @@
         expect(params).to eq('q' => 'foo')
       end
     end
+
+    context 'deleting deep item from to_h' do
+      let(:params) { { foo: { bar: [] } } }
+
+      it 'does not mutate search_state to deep mutate search_state.to_h' do
+        params = search_state.to_h
+        params[:foo][:bar] << 'buzz'
+
+        expect(search_state.to_h).to eq('foo' => { 'bar' => [] })
+        expect(params).to eq('foo' => { 'bar' => ['buzz'] })
+      end
+    end
   end
 
   describe 'interface compatibility with params' do