-
Notifications
You must be signed in to change notification settings - Fork 255
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Do not mutate search_state when mutating search_state.to_h
`Blacklight::SearchState#to_h` needs to return a dupe of it's internal state @params not a reference to it. Otherwise whatever mutation you do to the reference gets reflected in the Blacklight::SearchState instance. It's unexpected behavior for the `to_h` method to expose the `Blacklight::SearchState` instance's copy of `@params` and it can lead to very confusing bugs.
- Loading branch information
Showing
2 changed files
with
13 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters