Merge pull request #2333 from dkinzer/issue-2234-fix-undefined-method…

…-for-nil-class Fix heading error when document has no fields.
projectblacklight · Sep 24, 2020 · d582cf5 · d582cf5
2 parents 59f4d81 + 95f39c9
commit d582cf5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/app/presenters/blacklight/document_presenter.rb b/app/presenters/blacklight/document_presenter.rb
@@ -46,7 +46,7 @@ def heading
 
       fields = Array.wrap(view_config.title_field) + [configuration.document_model.unique_key]
       f = fields.lazy.map { |field| field_config(field) }.detect { |field_config| field_presenter(field_config).any? }
-      field_value(f, except_operations: [Rendering::HelperMethod])
+      f ? field_value(f, except_operations: [Rendering::HelperMethod]) : ""
     end
 
     def display_type(base_name = nil, default: nil)

diff --git a/spec/presenters/blacklight/show_presenter_spec.rb b/spec/presenters/blacklight/show_presenter_spec.rb
@@ -143,6 +143,14 @@ def mock_document_app_helper_url *args
       config.show.title_field = Blacklight::Configuration::Field.new(field: 'x', values: ->(*_) { 'hardcoded' })
       expect(subject.heading).to eq 'hardcoded'
     end
+
+    context "when empty document" do
+      let(:document) { SolrDocument.new({}) }
+
+      it "returns an empty string as the heading" do
+        expect(subject.heading).to eq("")
+      end
+    end
   end
 
   describe "#html_title" do