Skip to content

Commit

Permalink
Merge 2fff31e into a0c6247
Browse files Browse the repository at this point in the history
  • Loading branch information
jcoyne committed Nov 1, 2018
2 parents a0c6247 + 2fff31e commit c799316
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
6 changes: 0 additions & 6 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -649,12 +649,6 @@ Style/RedundantBegin:
Exclude:
- 'lib/blacklight/configuration/fields.rb'

# Offense count: 3
# Cop supports --auto-correct.
Style/RedundantFreeze:
Exclude:
- 'app/helpers/blacklight/render_partials_helper_behavior.rb'

# Offense count: 5
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
Expand Down
4 changes: 2 additions & 2 deletions app/helpers/blacklight/render_partials_helper_behavior.rb
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ def document_partial_name(document, base_name = nil)
def type_field_to_partial_name(_document, display_type)
# using "_" as sep. to more closely follow the views file naming conventions
# parameterize uses "-" as the default sep. which throws errors
underscore = '_'.freeze
Array(display_type).join(' '.freeze).tr('-'.freeze, underscore).parameterize(separator: underscore)
underscore = '_'
Array(display_type).join(' ').tr('-', underscore).parameterize(separator: underscore)
end

##
Expand Down

0 comments on commit c799316

Please sign in to comment.