Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next/Previous buttons on show page shows wrong results #1278

Closed
jcoyne opened this issue Nov 4, 2015 · 3 comments
Closed

Next/Previous buttons on show page shows wrong results #1278

jcoyne opened this issue Nov 4, 2015 · 3 comments

Comments

@jcoyne
Copy link
Member

jcoyne commented Nov 4, 2015

When you have two sessions open.

  1. Open one tab: http://demo.projectblacklight.org/?utf8=%E2%9C%93&search_field=all_fields&q=women Note: You should see 425 results
  2. Open another tab: http://demo.projectblacklight.org/?utf8=%E2%9C%93&search_field=all_fields&q=virginia Note: You should see 34 results
  3. On the first tab click the first search result. You will see "1 of 34" which is wrong. It should be "1 of 425"

This is because the search pagination is stored in the session. It is assumed that you only have one session at a time.
@cbeer
Copy link
Member

cbeer commented Nov 4, 2015

I thought we fixed this in #619. I wonder what changed.

@jcoyne
Copy link
Member Author

jcoyne commented Nov 4, 2015

This bug exists in searchworks too.

@mejackreed mejackreed mentioned this issue Nov 4, 2015
Closed
@cbeer
Copy link
Member

cbeer commented Nov 5, 2015

Fixed in #1280

@cbeer cbeer closed this as completed Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcoyne @cbeer