Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for compatibility with bootstrap 4.0.0 alpha 6 #1607

Closed
jcoyne opened this issue Jan 8, 2017 · 0 comments
Closed

Fix for compatibility with bootstrap 4.0.0 alpha 6 #1607

jcoyne opened this issue Jan 8, 2017 · 0 comments

Comments

@jcoyne
Copy link
Member

jcoyne commented Jan 8, 2017

Build is currently failing with:

       Undefined variable: "$font-size-root".
     # ./app/assets/stylesheets/blacklight/_icons.scss:3
     # ./app/assets/stylesheets/blacklight/_blacklight_base.scss:24
     # ./app/assets/stylesheets/blacklight/blacklight.scss:5
     # ./.internal_test_app/app/assets/stylesheets/blacklight.scss:3

Additionally, alpha 6 drops the -xs which we are using:

app/views/catalog/_facet_index_navigation.html.erb:  <%= link_to t('blacklight.search.facets.clear'), @pagination.params_for_resort_url('index', search_state.to_h.except(@pagination.request_keys[:prefix])), data: { blacklight_modal: "preserve" }, class: ['btn btn-secondary btn-xs', ('disabled' unless @pagination.prefix.present?)].join(' ') %>
app/views/catalog/_facet_index_navigation.html.erb:  <ol class="pagination pagination-xs">
app/views/catalog/_facets.html.erb:  <div id="facet-panel-collapse" class="collapse navbar-toggleable-xs">
app/views/shared/_header_navbar.html.erb:    <button class="navbar-toggler hidden-xs-up" type="button" data-toggle="collapse" data-target="#user-util-collapse" aria-controls="user-util-collapse" aria-expanded="false" aria-label="Toggle navigation"></button>
app/views/shared/_header_navbar.html.erb:    <div class="collapse navbar-toggleable-xs float-md-right" id="user-util-collapse">

We can also drop the .nav base class from:

app/views/catalog/_home_text.html.erb:  <nav class="nav nav-pills">
app/views/catalog/_show_tools.html.erb:    <ul class="nav nav-pills nav-stacked">
app/views/shared/_user_util_links.html.erb:<ul class="nav navbar-nav">
jcoyne added a commit that referenced this issue Jan 8, 2017
@cbeer cbeer closed this as completed in 5baad1a Jan 9, 2017
cbeer added a commit that referenced this issue Jan 9, 2017
@cbeer cbeer added this to Done in Blacklight 7.0 Release Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant