Facet queries are not passed through without adding a facet field #2401
Comments
mejackreed
added a commit
to geoblacklight/geoblacklight
that referenced
this issue
Jan 5, 2021
…test Needed until projectblacklight/blacklight#2401 is resolved.
banukutlu
pushed a commit
to psu-libraries/psulib_blacklight
that referenced
this issue
May 18, 2021
banukutlu
pushed a commit
to psu-libraries/psulib_blacklight
that referenced
this issue
May 19, 2021
banukutlu
pushed a commit
to psu-libraries/psulib_blacklight
that referenced
this issue
May 20, 2021
* need to explicitly define facet queries, see here projectblacklight/blacklight#2401
|
Just my two cents, but I think the current behavior is the correct behavior. In fact, I have an open ticket from way back when trying to make it act like this: #1989 . I explain it in the ticket but the gist of it is that it helps prevent sending facets defined for a controller when the facet is in the URL parameter actually there for another controller. At Temple we run into this a lot because we have 4 different search controllers all potentially adding facet parameters to the URL that should not be acted upon by all the search controllers. I also have a related ticket at projectblacklight/blacklight_range_limit#169. |
sandbergja
added a commit
to pulibrary/orangelight
that referenced
this issue
Feb 24, 2022
Blacklight now needs facets to be defined in the catalog controller before it can display them. See projectblacklight/blacklight#2401 This facet is linked from the subject browse and from show pages, so let's add it to the catalog controller.
carolyncole
pushed a commit
to pulibrary/orangelight
that referenced
this issue
Feb 25, 2022
Blacklight now needs facets to be defined in the catalog controller before it can display them. See projectblacklight/blacklight#2401 This facet is linked from the subject browse and from show pages, so let's add it to the catalog controller.
|
Closing as this is now the specced behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
My guess is this was introduced around #2371. Previously, facet queries could be used by the application without having to explicitly define it.
For example:
http://127.0.0.1:3000/catalog?f%5Bdc_source_sm%5D%5B%5D=princeton-1r66j405wwould filter results, withoutdc_source_smbeing defined. See failing testsearch_spechttps://app.circleci.com/pipelines/github/geoblacklight/geoblacklight/663/workflows/4a2ddcea-9ab2-401f-8c95-485969930c93/jobs/4878The text was updated successfully, but these errors were encountered: