7.x delegate normalization to filters #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstraintsHelperBehavior
- FilterFields are responsible for normalization of filter field data from params - Base permitted search params are configurable in Blacklight:Configuration - class methods for param normalization are deprecated Co-authored-by: Justin Coyne <jcoyne@justincoyne.com>
barmintor
force-pushed
the
7.x-delegate-normalization-to-filters
branch
from
d9825e5
to
1f1c706
Compare
|
@cbeer I needed to make an addition to the |
jcoyne
approved these changes
Apr 20, 2022
|
Does this need a forward port to main? |
This was referenced Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I was thinking re: using filter field definitions to sanitize the params.
Fixes #2683
Fixes
See also: #2401