Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing .constraints-container to display:flex has possibly undesirable side-effects #2552

Open
jrochkind opened this issue Nov 23, 2021 · 0 comments
Open

changing .constraints-container to display:flex has possibly undesirable side-effects #2552

jrochkind opened this issue Nov 23, 2021 · 0 comments

Comments

@jrochkind
Copy link
Member

jrochkind commented Nov 23, 2021 •
edited

#2469 changes the .constraints-container to display: flex in order to improve pixel alignment.

But for long lines, it can change the layout in other ways that may be undesirable.

After #2469, with display:flex, a stock BL 7.21.2 app:

Screen Shot 2021-11-23 at 4 32 36 PM

Screen Shot 2021-11-23 at 4 33 07 PM

Manually changing .constraints-container back to display:block

Screen Shot 2021-11-23 at 4 35 52 PM

Screen Shot 2021-11-23 at 4 33 39 PM

Some issues with lack of spacing between the line when it wraps, but a lot closer to desirable I think?

solution?

I wonder if the display: flex should be reverted, and another solution found to the pixel alignment? Alternately, I guess there might be a way to add more CSS to make it wrap better even under display:flex (maybe also need to add a flex-wrap: wrap, white-space: no-wrap, and possibly other flex alignment properties?), but just want to make sure we're not adding workarounds on top of workarounds in increasingly hairy ways (I don't personally understand the original issue in #2469 or why display:flex solved it).

Any thoughts @cbeer?
jrochkind added a commit to sciencehistory/scihist_digicoll that referenced this issue Nov 23, 2021
@jrochkind
Override Blacklight changed CSS to put .constraints-container back to…
da6c030 
… display:block

We had written some custom CSS for display:block that doesn't work when BL 7.20.0 changes to display:flex. The display:flex also causes some other display we find undesirable. projectblacklight/blacklight#2552

We'll just stick with display:block at least for now, although diverging from Blacklight CSS further increases possible maintenance risk.

Ref #1478
@jrochkind jrochkind mentioned this issue Nov 23, 2021
Merged
cbeer added a commit that referenced this issue Nov 24, 2021
@cbeer
Allow constraints to wrap across lines
6ff0356 
Fixes the problem reported in #2552
@cbeer cbeer mentioned this issue Nov 24, 2021
Merged
cbeer added a commit that referenced this issue Nov 26, 2021
@cbeer
Allow constraints to wrap across lines
9a675bb 
Fixes the problem reported in #2552
@cbeer cbeer mentioned this issue Nov 26, 2021
Merged
cbeer added a commit that referenced this issue Nov 28, 2021
@cbeer
Allow constraints to wrap across lines
4a715ad 
Fixes the problem reported in #2552
cbeer added a commit that referenced this issue Jul 31, 2022
@cbeer
Allow constraints to wrap across lines
d059d94 
Fixes the problem reported in #2552
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrochkind