Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blacklight upgrade resulted in messy layout #1478

Closed
jrochkind opened this issue Nov 23, 2021 · 3 comments
Closed

Blacklight upgrade resulted in messy layout #1478

jrochkind opened this issue Nov 23, 2021 · 3 comments
Assignees
@jrochkind

Comments

@jrochkind
Copy link
Contributor

At #1469, we upgraded from Blacklight 7.19.2 to 7.21.0.

That seems to have disturbed the custom stying of the "you searched for" section. Not sure why it would change on BL's end, and haven't yet confirmed for sure that's what happened.

Screen Shot 2021-11-23 at 3 12 50 PM

We could roll back while we investigate, or just figure out the fix.

I'm going to make this a priority to investigate (ping @apinkney0696 ).
@jrochkind jrochkind self-assigned this Nov 23, 2021
@jrochkind
Copy link
Contributor Author

confirmed in dev that downgrading to Blacklight 7.19.2 fixes the problem. I wonder why/how the BL CSS changed, investigating more.

@jrochkind
Copy link
Contributor Author

I can't see anything that's different in the html/css code. Very mysterious.

@jrochkind
Copy link
Contributor Author

Aha, I think it's this one in Blacklight 7.20.0, I don't know why it was done.

projectblacklight/blacklight@73d122e

I guess we could just put display:block back on .constraints_container... I have confirmed that fixes it.

Not sure if we should just hackily do that, as opposed to trying to figure out a new way to do it with that being flex.

jrochkind added a commit that referenced this issue Nov 23, 2021
@jrochkind
Override Blacklight changed CSS to put .constraints-container back to…
da6c030 
… display:block

We had written some custom CSS for display:block that doesn't work when BL 7.20.0 changes to display:flex. The display:flex also causes some other display we find undesirable. projectblacklight/blacklight#2552

We'll just stick with display:block at least for now, although diverging from Blacklight CSS further increases possible maintenance risk.

Ref #1478
@jrochkind jrochkind mentioned this issue Nov 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrochkind jrochkind

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrochkind