Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a 7.x deprecation for the movement of Blacklight::Engine config into a single top-level accessor in 8.0 #2607

Closed
barmintor opened this issue Jan 19, 2022 · 1 comment
Closed

Create a 7.x deprecation for the movement of Blacklight::Engine config into a single top-level accessor in 8.0 #2607

barmintor opened this issue Jan 19, 2022 · 1 comment
Assignees
@barmintor
Labels
Release-7.x Applies to the 7.x release line

Comments

@barmintor
Copy link
Contributor

barmintor commented Jan 19, 2022 •
edited

See also #2083

The top-level keys in 7.x were:
bookmarks_http_method
sms_mappings
email_regexp
enable_search_bar_autofocus (this may be a bug, see #2609 )
facet_missing_param (needs to be moved to second-level in main see #2608 )

Is there a way to wrap accessor reference to these keys in the 7.x Rails::Engine::Configuration, acknowledging that direct attribute access may be evaded?
@barmintor barmintor mentioned this issue Jan 19, 2022
Merged
@barmintor barmintor self-assigned this Jan 19, 2022
barmintor added a commit that referenced this issue Jan 19, 2022
@barmintor
deprecate Blacklight::Engine.config access without top-level key
68b8410 
- #2607
- move facet_missing_param to second-level key #2608
barmintor added a commit that referenced this issue Jan 19, 2022
@barmintor
deprecate Blacklight::Engine.config access without top-level key
4553b1b 
- #2607
- move facet_missing_param to second-level key #2608
@barmintor barmintor added the Release-7.x Applies to the 7.x release line label Jan 20, 2022
cbeer pushed a commit that referenced this issue Jan 22, 2022
@barmintor @cbeer
deprecate Blacklight::Engine.config access without top-level key
c4fe81c 
- #2607
- move facet_missing_param to second-level key #2608
@barmintor
Copy link
Contributor Author

Done in #2610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmintor barmintor

Labels
Release-7.x Applies to the 7.x release line
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@barmintor