Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate engine config keys #2610

Merged
merged 4 commits into from
Jan 22, 2022
Merged

Deprecate engine config keys #2610

merged 4 commits into from
Jan 22, 2022

Conversation

barmintor
Copy link
Contributor

  • Deprecation warnings for top-level config key access
  • moved an erroneously excluded key behind Blacklight::Engine.config.blacklight
  • moved the default value for a key intended to be in Blacklight::Configuration out of Blacklight::Engine.config

@barmintor barmintor requested a review from cbeer January 19, 2022 18:39
@barmintor
deprecate Blacklight::Engine.config access without top-level key
4553b1b 
- #2607
- move facet_missing_param to second-level key #2608
@barmintor
Copy link
Contributor Author

Aargh.

@barmintor barmintor mentioned this pull request Jan 19, 2022
Merged
@barmintor barmintor added the Release-7.x Applies to the 7.x release line label Jan 20, 2022
@cbeer cbeer merged commit 4764723 into release-7.x Jan 22, 2022
@cbeer cbeer deleted the deprecate_engine_config_keys branch January 22, 2022 16:38
This was referenced May 10, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeer cbeer Awaiting requested review from cbeer

Assignees
No one assigned
Labels
Release-7.x Applies to the 7.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barmintor @cbeer @jcoyne