-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sidecar templates for icon components #2723
Comments
@barmintor yeah, we could do that. I only made these class variable configuration as that seemed more "APIish". I'm not convinced that "just override a template" is a very good pattern in that it doesn't allow blacklight to evolve without breaking things in peoples apps. |
Also good points! But I want to capture the ideas that came up in the call. |
This works, but I'm not sure it's better. Something to think about. |
@jcoyne I also think, to your point, that we need to document that the component templates are private API. I think the compiler override is a necessary bridge, but it shouldn't be recommended practice. |
On the committers' call @hackartisan asked whether we could leverage the limited override of sidecar templates from
Blacklight::Component
to provide a way to get inline SVG from the icon components without having the svg source in Ruby.One way to do this would be to have a raw template.
See also conversation on #2670
The text was updated successfully, but these errors were encountered: