Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ViewComponents promoted _sidecar_files from experimental #2816

Closed
adjam opened this issue Sep 28, 2022 · 1 comment · Fixed by #2818
Closed

ViewComponents promoted _sidecar_files from experimental #2816

adjam opened this issue Sep 28, 2022 · 1 comment · Fixed by #2818

Comments

@adjam
Copy link

adjam commented Sep 28, 2022

https://github.com/ViewComponent/view_component/blob/3c13f004a316efc57ffd597fad1db9be4a4e447d/docs/CHANGELOG.md#2740

_sidecar_files is no longer used as of view_component 2.74.0, instead should use sidecar_files
@adjam
Copy link
Author

adjam commented Sep 28, 2022

blacklight/lib/blacklight/component.rb

Line 26 in 3af9ad3

component_class._sidecar_files(extensions).each_with_object([]) do |path, memo|
seems to be the only use in BL

@jcoyne jcoyne closed this as completed in 3e6e51f Sep 29, 2022
jcoyne added a commit that referenced this issue Sep 29, 2022
@jcoyne
Merge pull request #2818 from projectblacklight/2816-view-component
52cefe6 
Support view_component 2.74; fixes #2816
cbeer added a commit that referenced this issue Sep 30, 2022
@cbeer
Support view_component 2.74; fixes #2816
82e658a
@barmintor barmintor mentioned this issue Nov 2, 2022
Closed
@hackartisan hackartisan mentioned this issue Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support view_component 2.74 projectblacklight/blacklight
1 participant
@adjam