Generate SearchBuilder into the host application #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,140 +1,6 @@ | |||
| module Blacklight | |||
| class SearchBuilder | |||
| extend Deprecation | |||
There was a problem hiding this comment.
I still don't understand why this can't be a class, and have ::SearchBuilder extend it if it needs to.. especially because the behavior defines #initialize, which screams class to me.
There was a problem hiding this comment.
That would be fine with me. I can rework it.
This gives plugins a place to add additional search methods without having an complex inheritance hierarchy.
jcoyne
force-pushed
the
generate_search_builder
branch
from
0e697c4
to
d870405
Compare
| def locate_search_builder_class | ||
| ::SearchBuilder | ||
| rescue NameError | ||
| Deprecation.warn(Configuration, "Your application is missing the SearchBuilder. Have you run `rails generate blacklight:search_builder`? Falling back to Blacklight::Solr::SearchBuilder") |
There was a problem hiding this comment.
Do we really need to deprecation Blacklight::Solr::SearchBuilder? It seems like it works fine as-is for common uses..
There was a problem hiding this comment.
I'm for removing as much code as possible, so I think that deprecating it is the thing to do.
cbeer
added a commit
that referenced
this pull request
Mar 20, 2015
Generate SearchBuilder into the host application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives plugins a place to add additional search methods without
having an complex inheritance hierarchy.