Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blacklight::SolrResponse#aggregations to abstract solr's various facet flavors #1162

Merged
merged 1 commit into from
Mar 21, 2015

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Mar 20, 2015

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 90.52% when pulling a109e65 on facet-refactor into b386f4e on master.

elsif collection.respond_to? :model_name and !collection.model_name.nil? # AR, Blacklight::PaginationMethods
collection.model_name.human.downcase
elsif collection.is_a?(::Kaminari::PaginatableArray)
'entry'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"entry" is our i18n label too.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 90.52% when pulling 7181ccf on facet-refactor into 37824fb on master.

@cbeer
Copy link
Member Author

cbeer commented Mar 21, 2015

Also, should fix #1130.

jcoyne added a commit that referenced this pull request Mar 21, 2015
Add Blacklight::SolrResponse#aggregations to abstract solr's various facet flavors
@jcoyne jcoyne merged commit 2af6fb8 into master Mar 21, 2015
@cbeer cbeer deleted the facet-refactor branch March 21, 2015 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants