Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When providing default or backwards-compatible options for a field if/un... #1165

Merged
merged 1 commit into from
Mar 22, 2015

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Mar 21, 2015

...less condition, don't overwrite the boolean false

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.56% when pulling 90c23e2 on field-config-if-defaults into 37824fb on master.

@jcoyne
Copy link
Member

jcoyne commented Mar 22, 2015

Looks good, but needs a rebase.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.51% when pulling 971bb29 on field-config-if-defaults into 04041f7 on master.

@cbeer cbeer force-pushed the field-config-if-defaults branch 2 times, most recently from a804066 to 2ab667f Compare March 22, 2015 02:11
…/unless condition, don't overwrite the boolean false
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.51% when pulling 501eedd on field-config-if-defaults into 04041f7 on master.

jcoyne added a commit that referenced this pull request Mar 22, 2015
When providing default or backwards-compatible options for a field if/un...
@jcoyne jcoyne merged commit 05f309c into master Mar 22, 2015
@cbeer cbeer deleted the field-config-if-defaults branch March 22, 2015 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants