Add facet prefix filtering when paginating within a facet #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| .pagination-xs { | ||
| li { | ||
| a, span { |
There was a problem hiding this comment.
Selector should have depth of applicability no greater than 2, but was 3
Each selector in a comma sequence should be on its own line
cbeer
force-pushed
the
peetucket-facet-filter-index
branch
2 times, most recently
from
0822295
to
372d17d
Compare
| # set :index_pagination to true if you want the pop-up window for large facets to have alphabetical index navigation | ||
| # (useful when user clicks "more" on a large facet and wants to navigate alphabetically across a large set of results) | ||
| # if you set :index_pagination to true, you MUST set :index_range to an array of characters that will be used to create the navigation (note: It is case sensitive when searching values) | ||
|
|
There was a problem hiding this comment.
The comment says to set :index_pagination => true but in the example :index_pagination is not set.
There was a problem hiding this comment.
Could case sensitivity be an option here?
There was a problem hiding this comment.
Thanks for catching that. I've tried to revise the comment to reflect the new configuration.
Solr's facet.prefix option is case-sensitive. It looks like, in Solr 5.1, they landed a new facet.contains parameter that may do case-insensitive filtering, so maybe there's hope for this in the future..
…x navigation as a bootstrap pagination widget
cbeer
force-pushed
the
peetucket-facet-filter-index
branch
from
372d17d
to
4bd3f56
Compare
jcoyne
added a commit
that referenced
this pull request
Oct 19, 2015
…r-index Add facet prefix filtering when paginating within a facet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1251. I took @peetucket's commit and tried to push logic down into the models and use some more bootstrap-y styling:
There's significant work left to make it a general purpose tool (say, disabling the prefixes that have 0 hits), but this may be good enough for some targeted use or in a very large index.