Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds autocomplete typeahead feature #1288

Merged
merged 3 commits into from
Nov 6, 2015
Merged

Adds autocomplete typeahead feature #1288

merged 3 commits into from
Nov 6, 2015

Conversation

mejackreed
Copy link
Contributor

Using twitter-typeahead, with a default solr schema suggester.

Had to punt on feature specs as I couldn't get it working

text-decoration: none;
}

.tt-suggestion p {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selector should have depth of applicability no greater than 2, but was 3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👊

# Trys the suggestor response to return suggestions if they are
# present
# @return [Array]
def suggestions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to build this into the normal Blacklight::Solr::Response?

cbeer added a commit that referenced this pull request Nov 6, 2015
Adds autocomplete typeahead feature
@cbeer cbeer merged commit 0f31a3f into master Nov 6, 2015
@cbeer cbeer deleted the typeahead branch November 6, 2015 14:13
@flyingzumwalt
Copy link

@mejackreed It occurred to me that you might want to use some of the documentation from https://github.com/flyingzumwalt/blacklight_suggest/blob/master/README.md I'm going to throw away the gem since it's redundant now (due to this PR) but it's basically the same code that's in this PR so the stuff in the README might be useful somewhere. Take a look.

@mejackreed
Copy link
Contributor Author

Thanks @flyingzumwalt ... i'll take a look and see where we can use that to improve the docs/wiki!

@ronan-mch
Copy link

Just to note that the maintenance status of the Twitter Typeahead plugin seems a bit unclear. There's a thread on the GitHub with a number of people complaining about lack of maintenance, the last commit to master was over six months ago and there's a large number of open PRs which don't seem to be going anywhere. There is a maintained fork at corejavascript which may be worth investigating for future releases.

@mejackreed
Copy link
Contributor Author

Good to note about that fork. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants