-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds autocomplete typeahead feature #1288
Conversation
text-decoration: none; | ||
} | ||
|
||
.tt-suggestion p { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Selector should have depth of applicability no greater than 2, but was 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👊
# Trys the suggestor response to return suggestions if they are | ||
# present | ||
# @return [Array] | ||
def suggestions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to build this into the normal Blacklight::Solr::Response
?
Adds autocomplete typeahead feature
@mejackreed It occurred to me that you might want to use some of the documentation from https://github.com/flyingzumwalt/blacklight_suggest/blob/master/README.md I'm going to throw away the gem since it's redundant now (due to this PR) but it's basically the same code that's in this PR so the stuff in the README might be useful somewhere. Take a look. |
Thanks @flyingzumwalt ... i'll take a look and see where we can use that to improve the docs/wiki! |
Just to note that the maintenance status of the Twitter Typeahead plugin seems a bit unclear. There's a thread on the GitHub with a number of people complaining about lack of maintenance, the last commit to master was over six months ago and there's a large number of open PRs which don't seem to be going anywhere. There is a maintained fork at corejavascript which may be worth investigating for future releases. |
Good to note about that fork. Thanks! |
Using twitter-typeahead, with a default solr schema suggester.
Had to punt on feature specs as I couldn't get it working