Consistently use FacetField#field when retrieving aggregation values #1449

cbeer · 2016-07-28T17:27:01Z

coveralls · 2016-07-28T17:34:37Z

Coverage decreased (-0.01%) to 77.029% when pulling cd56723 on facet-fields into c31a190 on master.

jcoyne · 2016-07-28T17:45:05Z

Please add a test for facet_by_field_name

houndci-bot · 2016-07-28T17:58:24Z

app/controllers/concerns/blacklight/facet.rb

+      return blacklight_config.facet_fields[field] if blacklight_config.facet_fields[field] && blacklight_config.facet_fields[field].field == field
+
+      # Find the facet field configuration for the solr field, or provide a default.
+      blacklight_config.facet_fields.find { |_, v| v.field.to_s == field.to_s } ||


Prefer detect over find.

coveralls · 2016-07-28T18:07:30Z

Coverage increased (+0.02%) to 77.06% when pulling b8e2875 on facet-fields into c31a190 on master.

…from the response

coveralls · 2016-07-28T18:21:26Z

Coverage increased (+0.02%) to 77.06% when pulling 9c6fbc1 on facet-fields into c31a190 on master.

Normalize solr field names to strings in the configuration

7820fcb

cbeer force-pushed the facet-fields branch from cd56723 to b8e2875 Compare July 28, 2016 17:58

houndci-bot reviewed Jul 28, 2016
View reviewed changes

Consistently use FacetField#field when retrieving aggregation values …

9c6fbc1

…from the response

cbeer force-pushed the facet-fields branch from b8e2875 to 9c6fbc1 Compare July 28, 2016 18:10

jcoyne merged commit 2d7ec3c into master Jul 28, 2016

jcoyne deleted the facet-fields branch July 28, 2016 18:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consistently use FacetField#field when retrieving aggregation values #1449

Consistently use FacetField#field when retrieving aggregation values #1449

cbeer commented Jul 28, 2016 •

edited

Loading

coveralls commented Jul 28, 2016 •

edited

Loading

jcoyne commented Jul 28, 2016

houndci-bot Jul 28, 2016

coveralls commented Jul 28, 2016 •

edited

Loading

coveralls commented Jul 28, 2016 •

edited

Loading

Consistently use FacetField#field when retrieving aggregation values #1449

Consistently use FacetField#field when retrieving aggregation values #1449

Conversation

cbeer commented Jul 28, 2016 • edited Loading

coveralls commented Jul 28, 2016 • edited Loading

jcoyne commented Jul 28, 2016

houndci-bot Jul 28, 2016

Choose a reason for hiding this comment

coveralls commented Jul 28, 2016 • edited Loading

coveralls commented Jul 28, 2016 • edited Loading

cbeer commented Jul 28, 2016 •

edited

Loading

coveralls commented Jul 28, 2016 •

edited

Loading

coveralls commented Jul 28, 2016 •

edited

Loading

coveralls commented Jul 28, 2016 •

edited

Loading