remove dependency in SearchState #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return facet_fields[field] if facet_fields[field] && facet_fields[field].field == field | ||
|
|
||
| # Find the facet field configuration for the solr field, or provide a default. | ||
| facet_fields.values.find { |v| v.field.to_s == field.to_s } || |
|
Makes sense to me. We definitely have an overall problem of modules not being properly isolated (anticipating features or dependencies in the includer's context, and not even bothering to check when included whether that is true or not). Can you rebase it? |
…ch is a controller concern, by moving #facet_configuration_for_field into Blacklight::Configuration and delegating
codeforkjeff
force-pushed
the
search-state-dependency
branch
from
147e5d5
to
0013a6b
Compare
2 similar comments
|
Thanks for looking at this so quickly! I've rebased this branch with master. |
|
Looks good to me. 👍 Thanks. @codeforkjeff. @cbeer would you care to take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blacklight::Controllerconveniently allows you to override#search_stateto provide your own subclass ofBlacklight::SearchState. But when I try to create such a subclass, I get an 'uninitialized constant Blacklight::Facet' error, because that's a controller concern that hasn't been loaded yet.This PR removes that dependency, making it possible to subclass SearchState.