-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No need to style sr-only elements #1634
Conversation
@@ -2,7 +2,7 @@ | |||
@extend .mb-2; | |||
} | |||
|
|||
span.constraints-label { | |||
.constraints-label { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this only used to style this .sr-only
element?
<span class="constraints-label sr-only"><%= t('blacklight.search.filters.title') %></span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as far as I can tell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just remove the style entirely? No reason to make some sr-only text bold, is there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's best. We didn't have sr-only in the 6 branch, so I didn't notice.
No description provided.