Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group facets into separate blocks based upon group specified on facet field in config #1651

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Group facets into separate blocks based upon group specified on facet field in config #1651

merged 1 commit into from
Mar 26, 2019

Conversation

cjcolvar
Copy link
Contributor

Fixes #704.

@cjcolvar cjcolvar mentioned this pull request Mar 28, 2017
Closed
@cbeer
Copy link
Member

cbeer commented Mar 31, 2017

I see a lot of similarities with #1417. I wonder if we can come up with a consistent approach for this kind of configuration grouping?

@barmintor
Copy link
Contributor

This is something that can be dealt with in a feature release, right?

@barmintor barmintor added this to the 7.x milestone Oct 23, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 94.788% when pulling 4b87e10 on facet_groups into df7e862 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 94.788% when pulling 4b87e10 on facet_groups into df7e862 on master.

@cjcolvar
Copy link
Contributor Author

@barmintor @cbeer I rebased this for kicks. Let me know if there is anything I can do or reworking of this PR that might make it palatable for 7.0.

@jkeck
Copy link
Contributor

jkeck commented Mar 26, 2019

:shipit:

@cbeer cbeer merged commit c659fa6 into master Mar 26, 2019
@cbeer cbeer deleted the facet_groups branch March 26, 2019 21:56
@cjcolvar
Copy link
Contributor Author

Now I need to upgrade to Blacklight 7 in order to pull in this change and get rid of my local overrides.

@jrochkind jrochkind modified the milestones: 7.x, 7.1 Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeer cbeer cbeer approved these changes

Assignees
No one assigned
Labels
Nice To Have
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

Grouping of facet fields
7 participants
@cjcolvar @cbeer @barmintor @coveralls @jkeck @jrochkind @carolyncole