Make "discard flash for xhr requests" a configurable behavior #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a "discard_flash_if_xhr" flag to the blacklight configuration. Added this config option both to the catalog_controller generator and lib/blacklight/configuration.rb to cover pre-existing applications - Blacklight::Controller will now check this flag before discarding the flash messages in the associated after_action method - Added a spec to more directly unit test the Blacklight::Controller module and added specs that test this discard behavior for the usual CRUD actions
1 task
…removed in 7.x. Also moved the config check to the after_action binding so that apps that have this turned off will not get the deprecation warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blacklight will by default discard flash messages for XHR requests. This is not always desirable, in particular when an application is using Turbolinks and performs an XHR post-redirect-get, the client will follow the redirect but the flash messages are lost. This PR adds a few changes to make this configurable by the application. Summary of changes:
Related: samvera/hyrax#2592
I'm targeting the 6.x branch for now, since this is what Hyrax uses. If this gets accepted I'll make a new PR for a related fix to master.