Errors and notices missing when nesting collections

[laritakr]

Descriptive summary

When nesting collections, the notices and errors do not display when adding or removing a parent collection, or adding or removing a subcollection. The notices are filled correctly and passed with the redirect, but are apparently eaten by Turbolinks. (Notices work appropriately for adding a subcollection as a new collection.)

The response after submitModalAjax is:

Turbolinks.clearCache()
Turbolinks.visit(“http://localhost:3000/dashboard/collections/parent_nested?locale=en“, {“action”:“replace”})

Turbolinks needs to be deactivated somehow, to allow the responses to use the controller redirect_to.

Rationale

It is important to have a confirmation of what is happening, particularly in the case where a collection cannot be nested because it would exceed the specified nesting depth. In this situation, nothing happens but there is no message to explain why. At least in the case of a successful nesting, you can see the nested collection on the new view.

Expected behavior

• In cases of valid nesting, a confirmation notice states that the colllections were nested.
• In cases of errors, one or more errors state why the collections cannot be nested.

Actual behavior

• The nesting completes normally through the UI and all specs pass.
• in /app/controllers/hyrax/dashboard/nest_collections_controller.rb, the appropriate notices and errors are loaded as expected.
• Confirmation notices do not appear after the redirect.
• A notice regarding the nesting depth does not appear after the redirect.
  (since the query service was expanded to do appropriate validation, it would be very unlikely that you would be able to produce the other flash errors via the UI without forcing an error in method valid_combined_nesting_depth? in /app/services/hyrax/collections/nested_collection_query_service.rb)

Steps to reproduce the behavior

• Create several collections of the same nestable collection type.
• Go to the show page for a collection.
• Select add to collection, choose a collection, and submit.
• The page redisplays and shows the newly linked parent.
• No confirmation notice appears.
• Select add a subcollection, choose a collection, and submit.
• The page redisplays and shows the newly linked child.
• No confirmation notice appears.
• Chain collections 5 nesting levels deep ("nesting_collection__deepest_nested_depth_isi":5)
• Select Create new collection as subcollection.
• Page redisplays, with no changes and no error notice.

[elrayle]

This should also look at addressing messages getting eaten when adding users/groups on the sharing tab. They were recently converted to AJAX processing and no longer display messages.

Related Work: PR #2832

[jgondron]

I've tracked this down to a collision in behavior with blacklight: projectblacklight/blacklight@4d9290f. The problem that blacklight is solving with this flash.discard isn't a problem in hyrax since turbolinks will override xhr post behavior on the rails and client side to force it to auto follow redirects, which will properly consume flash messages (see https://github.com/turbolinks/turbolinks-rails/blob/master/lib/turbolinks/redirection.rb#L13).

I'm looking into proposing a change to make this behavior configurable in blacklight, since I suspect this will likely become a frequent issue for it with the recent "turbolinks by default" integration in rails.