Avoid unnecessary instantiation of data object #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to use with Elasticsearch due to: elastic/elasticsearch-rails#804
mjgiarlo
reviewed
Jun 28, 2018
| @@ -65,7 +65,7 @@ def track | |||
| path = uri.query ? "#{uri.path}?#{uri.query}" : uri.path | |||
| redirect_to path, status: 303 | |||
| else | |||
| redirect_to blacklight_config.document_model.new(id: params[:id]), status: 303 | |||
| redirect_to({ action: :show, id: params[:id] }, status: 303) | |||
There was a problem hiding this comment.
It's not clear to me that the code you removed is not necessary. Can you explain?
There was a problem hiding this comment.
It's not necessary, because the tests show the intended behavior is unchanged.
mjgiarlo
approved these changes
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to use with Elasticsearch due to:
elastic/elasticsearch-rails#804