Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin selenium-webdriver to avoid DevToolsActivePort file doesn't exist… #1912

Merged
merged 1 commit into from Jun 27, 2018
Merged

Pin selenium-webdriver to avoid DevToolsActivePort file doesn't exist… #1912

merged 1 commit into from Jun 27, 2018

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jun 26, 2018

@jcoyne jcoyne mentioned this pull request Jun 26, 2018
Closed
@mjgiarlo
Copy link
Member

This change looks fine to me, though pinning to patch-level releases is suboptimal. We can revisit that when the underlying issue allows the dependency to be more loosely pinned.

@jcoyne jcoyne merged commit ac2ad4a into master Jun 27, 2018
@jcoyne jcoyne deleted the pin-webdriver branch June 27, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjgiarlo mjgiarlo mjgiarlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcoyne @mjgiarlo