Extract reflect_fields method to the repository #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgiarlo
reviewed
Jun 28, 2018
| repository = repository_class.new(self) | ||
| repository.send_and_receive('admin/luke', params: { fl: '*', 'json.nl' => 'map' })['fields'] | ||
| end | ||
| repository = repository_class.new(self) |
There was a problem hiding this comment.
Can you safely remove the condition around this?
There was a problem hiding this comment.
The tests seem to pass. I can think of no reason why we can't require repository implementations to implement this interface.
There was a problem hiding this comment.
I don't think it's a problem; I don't remember what the luke response looks like, but if we think something similar will work cross-repository, I don't see a problem with it.
mjgiarlo
approved these changes
Jun 28, 2018
cbeer
reviewed
Jul 4, 2018
| end | ||
| end | ||
| end | ||
|
|
||
| def luke_fields |
This allows the repository to implement reflect_fields and allows us to remove a conditional.
jkeck
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the repository to implement reflect_fields and allows us to
remove a conditional.