Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate test #1917

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Remove duplicate test #1917

merged 1 commit into from
Jul 25, 2018

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jun 28, 2018

The exception behavior is already tested in the test above and general
handler behavior is tested in
spec/models/blacklight/solr/repository_spec.rb

@coveralls
Copy link

coveralls commented Jun 28, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.002%) to 94.588% when pulling 63fac54 on duplicate_test into 89f71c2 on master.

mjgiarlo
mjgiarlo approved these changes Jun 28, 2018
View reviewed changes
Copy link
Member

@mjgiarlo mjgiarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@jcoyne
Remove duplicate test
63fac54 
The exception behavior is already tested in the test above and general
handler behavior is tested in
spec/models/blacklight/solr/repository_spec.rb
@jkeck jkeck merged commit 6ea0849 into master Jul 25, 2018
@jkeck jkeck deleted the duplicate_test branch July 25, 2018 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjgiarlo mjgiarlo mjgiarlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcoyne @coveralls @mjgiarlo @jkeck