Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mocking to use the search_service #1919

Merged
merged 1 commit into from Jun 29, 2018
Merged

Update mocking to use the search_service #1919

merged 1 commit into from Jun 29, 2018

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jun 29, 2018

The existing mocks were no longer doing anything since the
search_service had been introduced into the CatalogController

@coveralls
Copy link

coveralls commented Jun 29, 2018 •
edited

Coverage Status

Coverage increased (+0.08%) to 94.753% when pulling b295109 on update-mocks into c100a3f on master.

@jcoyne
Update mocking to use the search_service
b295109 
The existing mocks were no longer doing anything since the
search_service had been introduced into the CatalogController
mjgiarlo
mjgiarlo approved these changes Jun 29, 2018
View reviewed changes
Copy link
Member

@mjgiarlo mjgiarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a lot cleaner now with the added mocking.

@jcoyne jcoyne merged commit 2e62757 into master Jun 29, 2018
@jcoyne jcoyne deleted the update-mocks branch June 29, 2018 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjgiarlo mjgiarlo mjgiarlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcoyne @coveralls @mjgiarlo