Regenerate rubocop todo list

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-03-28 15:21:19 -0700 using RuboCop version 0.54.0.
+# on 2018-06-29 11:08:53 -0500 using RuboCop version 0.56.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -30,7 +30,7 @@ Layout/ClosingParenthesisIndentation:
   Exclude:
     - 'app/views/catalog/index.atom.builder'
 
-# Offense count: 95
+# Offense count: 93
 # Cop supports --auto-correct.
 Layout/EmptyLineAfterMagicComment:
   Enabled: false
@@ -121,13 +121,16 @@ Layout/SpaceBeforeFirstArg:
 
 # Offense count: 7
 # Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: space, no_space
 Layout/SpaceInsideParens:
   Exclude:
     - 'app/views/catalog/_document.rss.builder'
     - 'app/views/catalog/index.atom.builder'
 
 # Offense count: 27
 # Cop supports --auto-correct.
+# Configuration parameters: AllowInHeredoc.
 Layout/TrailingWhitespace:
   Exclude:
     - 'app/views/catalog/_document.atom.builder'
@@ -149,7 +152,7 @@ Lint/UselessAssignment:
     - 'lib/blacklight/routes/searchable.rb'
     - 'lib/railties/blacklight.rake'
 
-# Offense count: 56
+# Offense count: 57
 Metrics/AbcSize:
   Max: 53
 
@@ -163,10 +166,10 @@ Metrics/BlockLength:
 Metrics/BlockNesting:
   Max: 4
 
-# Offense count: 3
+# Offense count: 2
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 189
+  Max: 169
 
 # Offense count: 19
 Metrics/CyclomaticComplexity:
@@ -177,7 +180,7 @@ Metrics/CyclomaticComplexity:
 Metrics/MethodLength:
   Max: 39
 
-# Offense count: 7
+# Offense count: 8
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
   Max: 211
@@ -219,7 +222,7 @@ Naming/PredicateName:
 
 # Offense count: 12
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to
+# AllowedNames: io, id, to, by, on, in, at
 Naming/UncommunicativeMethodParamName:
   Exclude:
     - 'app/models/blacklight/facet_paginator.rb'
@@ -230,6 +233,19 @@ Naming/UncommunicativeMethodParamName:
     - 'lib/blacklight/search_state.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
+# Offense count: 3
+# Cop supports --auto-correct.
+Performance/RegexpMatch:
+  Exclude:
+    - 'app/helpers/blacklight/url_helper_behavior.rb'
+    - 'lib/blacklight/configuration/fields.rb'
+    - 'lib/blacklight/solr/search_builder_behavior.rb'
+
+# Offense count: 1
+Performance/UnfreezeString:
+  Exclude:
+    - 'lib/generators/blacklight/install_generator.rb'
+
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent.
@@ -299,7 +315,7 @@ Style/ConditionalAssignment:
   Exclude:
     - 'lib/blacklight/solr/response/spelling.rb'
 
-# Offense count: 91
+# Offense count: 94
 Style/Documentation:
   Enabled: false
 
@@ -339,12 +355,20 @@ Style/GuardClause:
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
-# Offense count: 33
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
+# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
+Style/HashSyntax:
+  Exclude:
+    - 'app/helpers/blacklight/url_helper_behavior.rb'
+
+# Offense count: 37
 # Cop supports --auto-correct.
 Style/IfUnlessModifier:
   Enabled: false
 
-# Offense count: 116
+# Offense count: 117
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline
@@ -370,9 +394,24 @@ Style/MutableConstant:
   Exclude:
     - 'lib/blacklight/solr/request.rb'
 
+# Offense count: 10
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+    - 'spec/**/*'
+    - 'app/helpers/blacklight/catalog_helper_behavior.rb'
+    - 'app/models/blacklight/solr/facet_paginator.rb'
+    - 'app/services/blacklight/search_service.rb'
+    - 'lib/blacklight/search_builder.rb'
+    - 'lib/blacklight/solr/response/facets.rb'
+    - 'lib/blacklight/solr/search_builder_behavior.rb'
+    - 'lib/railties/blacklight.rake'
+
 # Offense count: 3
 # Cop supports --auto-correct.
-# Configuration parameters: AllowSafeAssignment.
+# Configuration parameters: AllowSafeAssignment, AllowInMultilineConditions.
 Style/ParenthesesAroundCondition:
   Exclude:
     - 'app/views/catalog/_document.atom.builder'
@@ -386,6 +425,18 @@ Style/PercentLiteralDelimiters:
     - 'lib/blacklight/engine.rb'
     - 'lib/blacklight/solr/request.rb'
 
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RedundantBegin:
+  Exclude:
+    - 'lib/blacklight/configuration/fields.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/RedundantFreeze:
+  Exclude:
+    - 'app/helpers/blacklight/render_partials_helper_behavior.rb'
+
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
@@ -405,7 +456,22 @@ Style/RescueStandardError:
     - 'lib/blacklight/configuration/fields.rb'
     - 'lib/railties/blacklight.rake'
 
-# Offense count: 14
+# Offense count: 12
+# Cop supports --auto-correct.
+# Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist.
+# Whitelist: present?, blank?, presence, try, try!
+Style/SafeNavigation:
+  Exclude:
+    - 'app/controllers/concerns/blacklight/bookmarks.rb'
+    - 'app/controllers/concerns/blacklight/controller.rb'
+    - 'app/services/blacklight/field_retriever.rb'
+    - 'lib/blacklight.rb'
+    - 'lib/blacklight/configuration/facet_field.rb'
+    - 'lib/blacklight/configuration/search_field.rb'
+    - 'lib/blacklight/search_state.rb'
+    - 'lib/blacklight/solr/search_builder_behavior.rb'
+
+# Offense count: 15
 # Cop supports --auto-correct.
 # Configuration parameters: MinSize.
 # SupportedStyles: percent, brackets