Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a routing spec for SearchHistoryController #1930

Merged
merged 3 commits into from
Jan 14, 2022
Merged

Add a routing spec for SearchHistoryController #1930

merged 3 commits into from
Jan 14, 2022

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jul 13, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 94.738% when pulling 95cc8ce on routing-spec into cd944c6 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 94.738% when pulling 95cc8ce on routing-spec into cd944c6 on master.

@coveralls
Copy link

coveralls commented Jul 13, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.005%) to 94.734% when pulling 9de0b28 on routing-spec into d46e933 on master.

@barmintor barmintor added this to the 7.x milestone Oct 11, 2018
@barmintor barmintor added this to In Scope in Blacklight 7.0 Release Oct 24, 2018
@barmintor barmintor moved this from In Scope to In Progress in Blacklight 7.0 Release Oct 24, 2018
@barmintor
Copy link
Contributor

This is a weird set of failures and successes - why wouldn't the routes be loaded in Rails 5.1.x?

@barmintor barmintor self-assigned this Nov 1, 2018
@barmintor barmintor moved this from In Progress to In Scope in Blacklight 7.0 Release Nov 26, 2018
@barmintor barmintor removed this from In Scope in Blacklight 7.0 Release Nov 26, 2018
@barmintor barmintor modified the milestones: 7.0, 7.x Nov 26, 2018
@cbeer cbeer moved this from Backlog to Review required in Blacklight Summit Triage Board Nov 9, 2021
barmintor
barmintor approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@barmintor barmintor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some test is better than no test!

@barmintor barmintor merged commit b7b8284 into main Jan 14, 2022
@barmintor barmintor deleted the routing-spec branch January 14, 2022 17:46
jcoyne added a commit that referenced this pull request Feb 25, 2022
@jcoyne
Merge pull request #2634 from projectblacklight/backport-1930
805c16a 
Backport #1930: Routing spec for /search_history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmintor barmintor barmintor approved these changes

Assignees

@barmintor barmintor

Labels
None yet
Projects
Blacklight Summit Triage Board
Review required
Milestone
7.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcoyne @coveralls @barmintor