Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using .on('ready') as it is deprecated in jquery 1.8 #1932

Merged
merged 1 commit into from
Jul 16, 2018
Merged

Avoid using .on('ready') as it is deprecated in jquery 1.8 #1932

merged 1 commit into from
Jul 16, 2018

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jul 13, 2018

Fixes #1929

@coveralls
Copy link

coveralls commented Jul 13, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 94.738% when pulling 6a40c2e on turbolinks-loader into d46e933 on master.

mejackreed
mejackreed reviewed Jul 13, 2018
View reviewed changes
app/javascript/blacklight/core.js
$(document).on(Blacklight.listeners(), function() {
Blacklight.activate();
});
Blacklight.listeners().forEach(function(listener) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the change here also related?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I changed Blacklight.listeners() to return an array of values that document.addEventListener can accept.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sounds good.

@jcoyne jcoyne merged commit fed4685 into master Jul 16, 2018
@jcoyne jcoyne deleted the turbolinks-loader branch July 16, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejackreed mejackreed mejackreed left review comments

@mjgiarlo mjgiarlo mjgiarlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcoyne @coveralls @mjgiarlo @mejackreed