Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary panel-body div #1940

Merged
merged 2 commits into from Jul 25, 2018
Merged

Remove unnecessary panel-body div #1940

merged 2 commits into from Jul 25, 2018

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jul 18, 2018

No description provided.

@coveralls
Copy link

coveralls commented Jul 18, 2018 •
edited

Coverage Status

Coverage remained the same at 94.578% when pulling eaa9b3e on remove-panel-body into 490932e on master.

jkeck
jkeck approved these changes Jul 25, 2018
View reviewed changes
Copy link
Contributor

@jkeck jkeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I validated that the facet is visually identical w/o this div.

@jkeck
Copy link
Contributor

jkeck commented Jul 25, 2018

@jcoyne this needs a rebase, but lgtm otherwise.

@camillevilla
Copy link
Member

camillevilla commented Jul 25, 2018 •
edited

Resolved the merge conflict per #1939 (Bootstrap card-block is now card-body).

@camillevilla camillevilla self-requested a review July 25, 2018 15:18
@jcoyne jcoyne merged commit f4cadd2 into master Jul 25, 2018
@jcoyne jcoyne deleted the remove-panel-body branch July 25, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkeck jkeck jkeck approved these changes

@camillevilla camillevilla camillevilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcoyne @coveralls @jkeck @camillevilla