Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonPresenter has facets_from_request available to itself #1945

Merged
merged 1 commit into from
Jul 24, 2018
Merged

JsonPresenter has facets_from_request available to itself #1945

merged 1 commit into from
Jul 24, 2018

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jul 20, 2018 •
edited
Loading

So we don't need to pass it in as an argument.

@coveralls
Copy link

coveralls commented Jul 20, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 94.593% when pulling 92e06b3 on facets_from_request into c2c9790 on master.

mjgiarlo
mjgiarlo approved these changes Jul 24, 2018
View reviewed changes
Copy link
Member

@mjgiarlo mjgiarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcoyne jcoyne merged commit 83e6784 into master Jul 24, 2018
@jcoyne jcoyne deleted the facets_from_request branch July 24, 2018 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjgiarlo mjgiarlo mjgiarlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcoyne @coveralls @mjgiarlo