Add a test for url_for_document, especially for a case that uses rail… #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
requested changes
Aug 25, 2018
lib/blacklight/search_state.rb
Outdated
| if respond_to?(:blacklight_config) && | ||
| blacklight_config.show.route && | ||
| (!doc.respond_to?(:to_model) || doc.to_model.is_a?(SolrDocument)) | ||
| if blacklight_config.show.route || (doc.respond_to?(:to_model) && doc == doc.to_model) |
There was a problem hiding this comment.
I think this || must still be an &&. Because the tests fail due to blacklight_config.show.route being nil
…s polymorphic routing magic
cbeer
force-pushed
the
1910-search-state
branch
from
3d2aa61
to
d4ee1d9
Compare
|
On closer inspection, these tests are all present in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s polymorphic routing magic.
Fixes #1910