Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the number of conditionals that are necessary in a ERB template #1980

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Reduce the number of conditionals that are necessary in a ERB template #1980

merged 1 commit into from
Oct 5, 2018

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Oct 4, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 94.614% when pulling f995c83 on fewer-conditionals into 0ac60aa on master.

@coveralls
Copy link

coveralls commented Oct 4, 2018 •
edited

Coverage Status

Coverage increased (+0.08%) to 94.767% when pulling 43dae95 on fewer-conditionals into 94749d5 on master.

mejackreed
mejackreed approved these changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@mejackreed mejackreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mejackreed mejackreed merged commit 8de6ad0 into master Oct 5, 2018
@mejackreed mejackreed deleted the fewer-conditionals branch October 5, 2018 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejackreed mejackreed mejackreed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcoyne @coveralls @mejackreed