Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the rendering pipeline to be configured per-instance #1996

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Enable the rendering pipeline to be configured per-instance #1996

merged 2 commits into from
Oct 10, 2019

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Oct 30, 2018

No description provided.

@jcoyne jcoyne added this to the 7.0 milestone Oct 30, 2018
@jcoyne jcoyne mentioned this pull request Oct 30, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.727% when pulling 9200f7e on configurable_pipeline into 2a23401 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.727% when pulling 9200f7e on configurable_pipeline into 2a23401 on master.

@coveralls
Copy link

coveralls commented Oct 30, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.002%) to 94.742% when pulling 285b7a6 on configurable_pipeline into 3a04827 on master.

mjgiarlo
mjgiarlo approved these changes Nov 8, 2018
View reviewed changes
Copy link
Member

@mjgiarlo mjgiarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving despite a couple trivial suggestions.

app/presenters/blacklight/rendering/pipeline.rb Outdated
@@ -2,27 +2,42 @@

module Blacklight
module Rendering
# The field rendering pipeline
# The field rendering pipeline.
# This takes a field and it's values and transforms them through a list of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/it's/its/

app/presenters/blacklight/rendering/pipeline.rb Outdated
# @param values [Array] the values for the field
# @param config [Blacklight::Configuration::Field] the field's configuration
# @param document [SolrDocument] the document
# @param context [Object] an execution context, used to execute the helper method in.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial: two spaces between the and helper

@jcoyne
Copy link
Member Author

jcoyne commented Nov 9, 2018

Thanks for the keen eye @mjgiarlo!

@mjgiarlo
Copy link
Member

@jcoyne Build went red. Restarted that build. Feel free to merge when this is green. ✔️

@bess bess merged commit 444cb91 into master Oct 10, 2019
@bess bess deleted the configurable_pipeline branch October 10, 2019 14:04
@bess bess mentioned this pull request Oct 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bess bess bess approved these changes

@mjgiarlo mjgiarlo mjgiarlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcoyne @coveralls @mjgiarlo @bess