Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate passing the label to link_to_document #1999

Closed
wants to merge 2 commits into from
Closed

Deprecate passing the label to link_to_document #1999

wants to merge 2 commits into from

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Oct 30, 2018

No description provided.

@jcoyne
Don't pass in the default values
721c3b3
@jcoyne
Deprecate passing the label to link_to_document
094a351 
This is not something we do in the Blacklight code and supporting extra
conditionals makes it harder to reason about.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 94.729% when pulling 094a351 on deprecate-label into 2a23401 on master.

@jcoyne jcoyne closed this Oct 31, 2018
@jcoyne jcoyne deleted the deprecate-label branch October 31, 2018 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcoyne @coveralls