Deprecate unnecessary conditions #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
deprecate-conditions
branch
from
cbbef46
to
94b11f2
Compare
barmintor
approved these changes
Oct 31, 2018
This makes the code easier to trace.
jcoyne
force-pushed
the
deprecate-conditions
branch
from
94b11f2
to
633b8ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the code easier to trace.
The Proc parameter was introduced way back in 9f1b79a#diff-d60c901f4d059652ee1ba78a44e7fc11R260 and I don't think its still necessary to maintain it.
Depends on #1998