Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a raw solr endpoint #2006

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Add a raw solr endpoint #2006

merged 1 commit into from
Nov 1, 2018

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Oct 31, 2018

Fixes #1968

@jrochkind
Copy link
Member

jrochkind commented Oct 31, 2018 •
edited

Is there any reason to be concerned that it may be possible not everything in the raw solr document is public?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 94.735% when pulling c881900 on raw-endpoint into 2b7b5fa on master.

@coveralls
Copy link

coveralls commented Oct 31, 2018 •
edited

Coverage Status

Coverage increased (+0.01%) to 94.735% when pulling c881900 on raw-endpoint into 2b7b5fa on master.

@jcoyne
Copy link
Member Author

jcoyne commented Oct 31, 2018

@jrochkind out of an abundance of caution, I think we should make people specify all the fields they want exposed. That's how the default show endpoint now works in BL 7...however this broke usecases that some people had, so this PR is an attempt to let them show everything if they change the configuration to turn it on.

@jcoyne jcoyne added this to In Progress in Blacklight 7.0 Release Oct 31, 2018
@jcoyne jcoyne added this to the 7.0 milestone Oct 31, 2018
barmintor
barmintor approved these changes Nov 1, 2018
View reviewed changes
Copy link
Contributor

@barmintor barmintor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does a good job of allowing an install to support mediated solr_document scraping a la GeoBlacklight without exposing default installations. 👍

@barmintor barmintor merged commit b57237e into master Nov 1, 2018
@barmintor barmintor moved this from In Progress to Done in Blacklight 7.0 Release Nov 1, 2018
@mejackreed mejackreed deleted the raw-endpoint branch November 1, 2018 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmintor barmintor barmintor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Blacklight 7.0 Release
  
Done
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcoyne @jrochkind @coveralls @barmintor