bump blacklight_marc #2030
Merged
bump blacklight_marc #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumping the version of blacklight_marc
jcoyne
reviewed
Nov 13, 2018
| @@ -88,7 +88,7 @@ def generate_blacklight_marc_demo | |||
| return unless options[:marc] | |||
|
|
|||
| blacklight_marc = String.new('blacklight-marc') | |||
| gem blacklight_marc, '~> 6.1' | |||
| gem blacklight_marc, '= 7.0.0.rc1' | |||
There was a problem hiding this comment.
Like "pre-release or greater of this dot release," right? Looking around on the internet, I can't seem to find documentation on how to specify this, the closest thing I could find was rubygems/bundler#1198 (comment). These seem like they're all possible, good options?
= 7.0.0.rc1 (I know this one works)
>= 7.0.0.a
>= 7.0.0.beta
~> 7.0.0.a
~> 7.0.0.beta
There was a problem hiding this comment.
Okay, how about < 8? I'm thinking we don't want to have to revisit this line once we release newer versions of blacklight-marc.
jcoyne
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bumping the version of blacklight_marc
connected to #1868
cc @barmintor