Improve performance of Search.delete_old_searches #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes projectblacklight#2062 Call delete_all instead of destroy_all to prevent loading relations in memory. This method is much faster (a single DELETE query) but does not execute callbacks or delete relations. That's not an issue now, but if the Search model is extended this method may need to be modified.
danschmidt5189
force-pushed
the
2062-delete_old_searches_in_batches
branch
from
d6cdb00
to
6f2748e
Compare
danschmidt5189
changed the title
|
@jcoyne Updated to use delete_all. I noted the potential problems in the commit message. |
|
Thanks @danschmidt5189. Great contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2062