Accept everything as the default routing constraint #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
requested changes
Mar 13, 2019
| @@ -45,7 +45,7 @@ class Engine < Rails::Engine | |||
|
|
|||
| config.routes = OpenStruct.new | |||
| # Set identifier_constraint to enforce a format for the document identifiers | |||
| config.routes.identifier_constraint = /[\w-]+/ | |||
| config.routes.identifier_constraint = /.+/ | |||
There was a problem hiding this comment.
Won't this break anyone using URLs with extensions?
There was a problem hiding this comment.
Explain what you mean by that.
There was a problem hiding this comment.
Keep in mind this is only for the "track" route: https://github.com/projectblacklight/blacklight/blob/v6.20.0/config/routes.rb#L10
…fig.identifier_constraint doesn't interfere
barmintor
force-pushed
the
improved_constraint
branch
from
1db14d7
to
849ad04
Compare
|
Added 2 routing specs to verify per @cbeer's review that format in the URL is not interfered with. Merging to |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.