Implement checkbox submit without jquery #2161
Conversation
jcoyne
force-pushed
the
checkbox-without-jquery
branch
from
27e78ec
to
8c59e26
Compare
| console.warn("do_bookmark_toggle_behavior is deprecated. Use doBookmarkToggleBehavior instead."); | ||
| return Blacklight.do_bookmark_toggle_behavior(); | ||
| } | ||
| }); //change form submit toggle to checkbox |
There was a problem hiding this comment.
Note: this is the generated (dist) code, jump to app/javascript/* for source changes.
jcoyne
force-pushed
the
checkbox-without-jquery
branch
from
6841766
to
887133a
Compare
jcoyne
force-pushed
the
checkbox-without-jquery
branch
from
887133a
to
2af3a7f
Compare
jcoyne
force-pushed
the
checkbox-without-jquery
branch
from
2af3a7f
to
052f408
Compare
jcoyne
force-pushed
the
checkbox-without-jquery
branch
2 times, most recently
from
0c76d3a
to
738fa7b
Compare
jcoyne
force-pushed
the
checkbox-without-jquery
branch
from
738fa7b
to
dd670ea
Compare
jcoyne
force-pushed
the
checkbox-without-jquery
branch
from
dd670ea
to
358b30a
Compare
| @@ -11,7 +10,6 @@ export default { | |||
| Autocomplete, | |||
| BookmarkToggle, | |||
| ButtonFocus, | |||
| CheckboxSubmit, | |||
There was a problem hiding this comment.
There still is a checkbox_submit.js with an export, why do these two lines get removed from index.js, is that right?
There was a problem hiding this comment.
Because it is imported by bookmark_toggle.js, which is the only place it is used.
There was a problem hiding this comment.
Makes sense, thanks! Is this possibly a backwards compat change, if a local app was using it? If so, that's maybe okay since we're shooting for major version? Just wanted to be clear (and is there anywhere we're listing backwards compat changes?)
There was a problem hiding this comment.
That was never available in a release. That file was just created 2 weeks back: 4976e2d
|
Can anyone confirm that this behavior is tested by some automated test that's running? If so, I feel more comfortable approving without manually testing myself or having the capacity to code-read it more cursorily. |
|
@jrochkind yes, it's tested via |
No description provided.