Commit compiled js needed to release v7.10.0 #2327
Conversation
|
Thanks Jack. Looks like 161 rubocop offenses. And there's this PR that looks like it's intended to fix this problem #2298. That PR needs a rebase though. |
mejackreed
force-pushed
the
commit-compiled-js
branch
from
383952f
to
060e00e
Compare
There was a problem hiding this comment.
So, just so I understand the process, this change was produced by running npm run js-compile-bundle locally. Once merged Jack you will run npm publish. Is that right?
I know this page contains details for general releases, but since that's not really what's going on here I just wanted to check my understanding. Also might it be a good idea, separately, to update that doc because it seems pretty different than reality? Like "Create a milestone in GitHub for the NEXT version." for example.
|
Yes that is what I am doing. I think generally most of that is stuff that should happen when creating release. And likely the milestone and email are the things that are being skipped. But I'd say we should strive for it so I would be 👍 for leaving it in. |
No description provided.