Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the class configuration defaults into Blacklight::Configuration.default_values #2522

Merged
merged 3 commits into from
Nov 18, 2021

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Nov 16, 2021

And, now that we've dropped Rails 5.x, we can use #deep_transform_values directly.

@cbeer cbeer force-pushed the config-defaults branch 3 times, most recently from 7093a4c to 43550c5 Compare November 17, 2021 20:19
@cbeer cbeer marked this pull request as ready for review November 18, 2021 13:15
@jcoyne
Copy link
Member

jcoyne commented Nov 18, 2021

@cbeer there is a conflict here that needs to be resolved.

@dkinzer
Copy link
Member

dkinzer commented Nov 18, 2021

Is there a way to keep track of these backwards incompatible changes to make the upgrade path easier?

@cbeer
Copy link
Member Author

cbeer commented Nov 18, 2021

These aren't backwards incompatible changes, just moving where/how the values are set initially.

@dkinzer
Copy link
Member

dkinzer commented Nov 18, 2021

@cbeer Yeah, sorry. I was focusing on the signature of the deep_transform_values method changing without taking into account that's a private mehod.

@dkinzer dkinzer merged commit 562ba13 into main Nov 18, 2021
@dkinzer dkinzer deleted the config-defaults branch November 18, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants