Explicity pass the documents to the render_document_index method #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps controller instance variables from appearing in the helpers
|
I know that this PR is towards the 8.x release, but I'm wondering if if makes sense to start to keep track of these types of backward incompatible changes in an upgrade path file somewhere so that it's easier to document how someone can upgrade from 7.x to 8.x. I think both of these templates are very popular to override. |
|
@dkinzer I'm seeing that @jcoyne also has a 7.x deprecation warning about this (here) and I've added it to the upgrade notes. Does that address your concern? |
bess
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps controller instance variables from appearing in the helpers